# Coverage is comparing with incorrect base branch **URL:** \ **Category:** Support\ **Tags:** golang, github\ **Created:** [February 21, 2023, 12:26am UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152 "2023-02-21T00:26:26Z")\ **Posts on this page:** 7\ **Page:** 1
**Author:** ![kevindiu](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/kevindiu/32/2909_2.png) [@kevindiu](https://community.codecov.com/u/kevindiu)\ **Post date:** [February 21, 2023, 12:26am UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152/1 "2023-02-21T00:26:26Z")
## Before submitting a topic, please confirm the following I have searched for similar issues before creating this topic. I have verified that my repository is using the [Codecov GitHub app](https://github.com/apps/codecov), if using GitHub I have [validated](https://docs.codecov.com/docs/codecov-yaml#validate-your-repository-yaml) my `codecov.yaml` configuration file. (no yaml is used) I have filled out the below sections to the best of my ability. ### Description The coverage report shows the incorrect coverage on the pull requests due to the coverage is comparing to incorrect base commit. > **[Code coverage done right.](https://app.codecov.io/gh/vdaas/vald/pull/1952)** > > Hosted coverage report highly integrated with GitHub, Bitbucket and GitLab. Awesome pull request comments to enhance your QA. The incorrect coverage is occurred in multiple pull requests. > **[Code coverage done right.](https://app.codecov.io/gh/vdaas/vald/pulls)** > > Hosted coverage report highly integrated with GitHub, Bitbucket and GitLab. Awesome pull request comments to enhance your QA. After checking the [basic commit on the Github](https://github.com/vdaas/vald/commit/97eed29), it shows that `This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.` ### CI/CD URL > > > Signed-off-by: kevindiu \ > > > > \### Description: > > > > … > This PR remove empty testing stubs, to avoid testing template changes affecting the implementation of empty testing stubs. > The testing stubs which are already implemented will not be removed or updated in this PR, even if it is generated by the legacy testing template. > > Since this changes causing a lots of testing file changes, it is very hard to review changes one by one. > Please review by looking at the code coverage changes on > https://app.codecov.io/gh/vdaas/vald/pull/1952 > > This PR has almost no affect on the code coverage changes, meaning that this PR only remove the empty testing stubs, without removing the implemented tests. > > > > \### Related Issue: > > > > > > > \### Versions: > > > > \- Go Version: 1.20 > \- Docker Version: 20.10.8 > \- Kubernetes Version: 1.22.0 > \- NGT Version: 2.0.9 > > \### Checklist: > > > > > \- \[x\] I have read the \[CONTRIBUTING\](https://github.com/vdaas/vald/blob/main/CONTRIBUTING.md) document and completed \[our CLA agreement\](https://cla-assistant.io/vdaas/vald). > \- \[x\] I have checked open \[Pull Requests\](https://github.com/vdaas/vald/pulls) for the similar feature or fixes? > > \### Special notes for your reviewer: ### Codecov Output ```auto /usr/bin/docker exec 1c432ee65d1f0425013e16c108454f996084010e510a9395bda27ed4dabc5008 sh -c "cat /etc/*release | grep ^ID" ==> linux OS detected https://uploader.codecov.io/latest/linux/codecov.SHA256SUM ==> SHASUM file signed by key id 806bb28aed779869 ==> Uploader SHASUM verified (20f9c9d78483fce977b6cc39e231a734a23bcd36f4d536bb7355222fb88d02bc codecov) ==> Running version latest ==> Running version v0.3.2 /__w/_actions/codecov/codecov-action/v3/dist/codecov -n -Q github-action-3.1.1 -f ./coverage.out -C a5dfbeb015d28d8b900d29076c8fb07414c98ec7 [2023-02-13T07:21:57.259Z] ['info'] _____ _ / ____ | | | | | _____ | | ______ _______ | | / _ \ / _` |/ _ \/ __/ _ \ \ / / | |___| (_) | (_| |__/ (_| (_) \ V / \ _____\___ / \ __,_|\___ |\ ___\___ / \_/ Codecov report uploader 0.3.2 [2023-02-13T07:21:57.277Z] ['info'] => Project root located at: /__w/vald/vald [2023-02-13T07:21:57.278Z] ['info'] -> Token found by environment variables [2023-02-13T07:21:57.291Z] ['info'] Searching for coverage files... [2023-02-13T07:21:57.438Z] ['info'] => Found 1 possible coverage files: ./coverage.out [2023-02-13T07:21:57.442Z] ['info'] Processing ./coverage.out... [2023-02-13T07:21:57.468Z] ['info'] Using manual override from args. [2023-02-13T07:21:57.469Z] ['info'] Detected GitHub Actions as the CI provider. [2023-02-13T07:21:57.471Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.1-uploader-0.3.2&token= ******* &branch=refactor%2Fremove-empty-test-stub&build=4159390414&build_url=https%3A%2F%2Fgithub.com%2Fvdaas%2Fvald%2Factions%2Fruns%2F4159390414&commit=a5dfbeb015d28d8b900d29076c8fb07414c98ec7&job=Coverage&pr=1950&service=github-actions&slug=vdaas%2Fvald&name=&tag=&flags=&parent= [2023-02-13T07:21:58.037Z] ['info'] https://app.codecov.io/github/vdaas/vald/commit/a5dfbeb015d28d8b900d29076c8fb07414c98ec7 https://storage.googleapis.com/codecov/v4/raw/2023-02-13/D0FF395BC3712B41960AC7811420E6DB/a5dfbeb015d28d8b900d29076c8fb07414c98ec7/c099fd9b-0dfd-4924-8215-301def08a4c8.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EJOGFN2JQ4OCTGA2MU5AEIT7OT5Z7HTFOAN2SPG4NWSN2UJYOY5U6LZQ%2F20230213%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20230213T072157Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=1284cc211b04a67b8e301a1c05f258a8a1e58fef0771545f2ec9e0ce9a91f6b4 [2023-02-13T07:21:58.037Z] ['info'] Uploading... [2023-02-13T07:21:58.238Z] ['info'] {"status":"success","resultURL":"https://app.codecov.io/github/vdaas/vald/commit/a5dfbeb015d28d8b900d29076c8fb07414c98ec7"} ``` ### Expected Results The coverage of the pull request should compare to the commit of the base branch of the pull request. ### Actual Results The coverage of the pull request is comparing to the incorrect commit. ### Additional Information The parent of the incorrect base commit, is actually belongs to [the PR/commit which is already merged to the main branch](https://github.com/vdaas/vald/commit/48cdb525f8e89bc82a230b4ca69b9030f65b002d), but we are not sure about how is it merged to the PR/commit. ---
**Author:** ![tom](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/tom/32/8_2.png) [@tom](https://community.codecov.com/u/tom)\ **Post date:** [February 22, 2023, 5:30pm UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152/2 "2023-02-22T17:30:59Z")
@kevindiu can you provide the SHA that you expect it to be comparing to? ---
**Author:** ![kevindiu](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/kevindiu/32/2909_2.png) [@kevindiu](https://community.codecov.com/u/kevindiu)\ **Post date:** [February 23, 2023, 10:11pm UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152/3 "2023-02-23T22:11:49Z")
Hi @tom Thank you for your reply. I expect it to compare with the main branch, which is `96afa5afbc7a9d7ebd0bcd97ca34533977b68fc9`. ---
**Author:** ![tom](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/tom/32/8_2.png) [@tom](https://community.codecov.com/u/tom)\ **Post date:** [February 24, 2023, 6:25pm UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152/4 "2023-02-24T18:25:11Z")
Got it, it is comparing to an earlier commit than the one expected, because that is the last commit on `main` where we have coverage. You can see that [here](https://app.codecov.io/github/vdaas/vald/commits). There are no commits on `main` that have coverage in the past 6 months. ---
**Author:** ![kevindiu](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/kevindiu/32/2909_2.png) [@kevindiu](https://community.codecov.com/u/kevindiu)\ **Post date:** [February 27, 2023, 2:08am UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152/5 "2023-02-27T02:08:11Z")
Thank you @tom !!! I will find out why the coverage is not updated on the main branch for a while, and I may ask if I have further questions, thank you!!! ---
**Author:** ![kevindiu](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/kevindiu/32/2909_2.png) [@kevindiu](https://community.codecov.com/u/kevindiu)\ **Post date:** [February 27, 2023, 7:30am UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152/6 "2023-02-27T07:30:32Z")
We have 1 PR merged to main branch recently, and the coverage is [updated on main branch](https://app.codecov.io/github/vdaas/vald/commits). I think the cause of not updating the coverage on main branch is that we forgot to update the default branch setting [here](https://app.codecov.io/gh/vdaas/vald/settings) when we update the main branch name before. I will keep update if we find anything new, thank you 🙂 ---
**Author:** ![tom](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/tom/32/8_2.png) [@tom](https://community.codecov.com/u/tom)\ **Post date:** [February 28, 2023, 1:13am UTC](https://community.codecov.com/t/coverage-is-comparing-with-incorrect-base-branch/4152/7 "2023-02-28T01:13:52Z")
@kevindiu ahh! Nice catch. Let me know if anything else is wrong!