# GitHub Check does not fail when Threshold crossed

**URL:** <https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825>\
**Category:** Bug Fixes\
**Tags:** javascript, github\
**Created:** [April 27, 2021, 3:10pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825 "2021-04-27T15:10:39Z")\
**Posts on this page:** 8\
**Page:** 1

<div class="post-metadata">

**Author:** ![SanketD92](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/sanketd92/32/1816_2.png) [@SanketD92](https://community.codecov.com/u/SanketD92)\
**Post date:** [April 27, 2021, 3:10pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/1 "2021-04-27T15:10:39Z")

</div>

_Please search for similar issues before creating a ticket._  
All fields below are required.

### Description

I’m trying to integrate CodeCov into a Create React App project (using pnpm) which contains testable code located in various subfolders within the repository. I set both `status.project.threshold` and `status.patch.threshold` in the codecov.yml file to pretty low values (0% as well as 0.1%). I verified that the codecov.yml [file](https://github.com/awslabs/service-workbench-on-aws/blob/mainline/codecov.yml) was valid using the bash validation command. GitHub App integration has been enabled for this repository.

I created a dummy [PR](https://github.com/awslabs/service-workbench-on-aws/pull/467) which removes existing unit tests (more than 2% project coverage), in order to trigger codecov thresholds set. This still does not fail my GitHub codecov check.

I’d like to know what configuration is incorrect/missing for this to work correctly. Also, why am I not seeing the codecov-specific checks “codecov/patch” and “codecov/project” as seen in this [PR](https://github.com/SanketD92/service-workbench-on-aws/pull/6)

### Commit SHAs

N/A (Not commit-specific)

### Repository

PR link added in description.

### CI/CD or Build URL

N/A

### Uploader

Bash uploader

### Expected Results

GitHub check should fail when CodeCov threshold is crossed.

---

<div class="post-metadata">

**Author:** ![tom](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/tom/32/8_2.png) [@tom](https://community.codecov.com/u/tom)\
**Post date:** [April 27, 2021, 3:29pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/2 "2021-04-27T15:29:27Z")

</div>

@SanketD92 I would highly recommend installing the [app integration](https://github.com/apps/codecov) to fix this issue for you.

---

<div class="post-metadata">

**Author:** ![SanketD92](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/sanketd92/32/1816_2.png) [@SanketD92](https://community.codecov.com/u/SanketD92)\
**Post date:** [April 27, 2021, 3:45pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/3 "2021-04-27T15:45:54Z")

</div>

@tom App integration has been configured for this repo. Permissions granted are:

## Permissions

- **Read** access to administration, code, issues, members, and metadata
- **Read** and **write** access to checks, commit statuses, and pull requests

Let me know if I’m misunderstanding something.

---

<div class="post-metadata">

**Author:** ![tom](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/tom/32/8_2.png) [@tom](https://community.codecov.com/u/tom)\
**Post date:** [April 27, 2021, 4:06pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/4 "2021-04-27T16:06:13Z")

</div>

@SanketD92 I’m seeing that it isn’t on [our end](https://app.codecov.io/gh/awslabs/service-workbench-on-aws/settings). If you’re sure it’s set, would you mind uninstalling and reinstalling? I think that should fix it for you.

---

<div class="post-metadata">

**Author:** ![SanketD92](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/sanketd92/32/1816_2.png) [@SanketD92](https://community.codecov.com/u/SanketD92)\
**Post date:** [April 27, 2021, 6:34pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/5 "2021-04-27T18:34:39Z")

</div>

@tom I see that repository access for awslabs/service-workbench-on-aws has been granted (on this [link](https://github.com/apps/codecov/installations/16544577))

---

<div class="post-metadata">

**Author:** ![tom](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/tom/32/8_2.png) [@tom](https://community.codecov.com/u/tom)\
**Post date:** [April 27, 2021, 6:57pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/6 "2021-04-27T18:57:10Z")

</div>

@SanketD92, I’m guessing something went wrong when getting the callback during installation. Are you able to uninstall and reinstall?

---

<div class="post-metadata">

**Author:** ![SanketD92](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/sanketd92/32/1816_2.png) [@SanketD92](https://community.codecov.com/u/SanketD92)\
**Post date:** [April 29, 2021, 6:26pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/7 "2021-04-29T18:26:32Z")

</div>

@tom Attempting uninstall and re-install now. I’ll keep you updated on this thread

---

<div class="post-metadata">

**Author:** ![SanketD92](https://yyz1.discourse-cdn.com/flex029/user_avatar/community.codecov.com/sanketd92/32/1816_2.png) [@SanketD92](https://community.codecov.com/u/SanketD92)\
**Post date:** [April 29, 2021, 8:07pm UTC](https://community.codecov.com/t/github-check-does-not-fail-when-threshold-crossed/2825/8 "2021-04-29T20:07:09Z")

</div>

That worked! Thanks @tom
