Before submitting a topic, please confirm the following I have searched for similar issues before creating this topic. I have verified that my repository is using the Codecov GitHub app , if using GitHub I have validated my codecov.yaml configuration file. I have filled out the below sections …

Hi @JoshuaKGoldberg , I’m sorry I lost track of this one. But here’s something I found when digging into this recent PR (#5825) . Clicking into the Codecov report shows us the HEAD and BASE [image] If there is a change, then we should see a difference between the two reports. Because this is happe…

Fantastic, thanks so much for looking into this Tom! Your pointers were spot on. We’d changed our CI to cache test results, but never added coverage data to the list of files restored from cache. And since PR branches have to be up-to-date with the main branch, the main branch was always failing to…

@JoshuaKGoldberg thanks for the feedback here, the main problem to summarize is that it was unclear that the number of coverage files uploaded was not the same. I’ll let the product team know about it.

Wait, sorry, just making sure we’re on the same page - for me it’s that Codecov was comparing coverage numbers against an outdated number. As in, the main branch coverage percentage was computed from not the latest commit to main.

@JoshuaKGoldberg ooo looks like we have some confusion. Can you point to a specific example with SHAs? What I think you’re saying is that we are comparing to a base commit that you are not expecting

I’m not confident that I’m correct here :smile:, it’s possible you’re right and I’m blatantly wrong… But, looking at the codecov report from the OP: Codecov Coverage data based on HEAD 5e9d356 compared to BASE 9ffdb05 9ffdb05 is the right commit on main.

@JoshuaKGoldberg I’m not sure I understand that scenario. 9ffdb05 is the correct BASE and we are showing it too?

Greetings to all, We have the same problem with the wrong coverage diff calculation within Codecov Coverage bot. Codecov Bot always takes the very outdated merge commit from base branch that was made in the last July. As we expect, the coverage should compare the last PR head branch commit and the …

@BAStos525 my guess is that you are making commits from a fork that is really behind the upstream repo. That’s probably why it needs to go so far back to find a commit that exists or that has coverage.

Thank you for the answer. Actually if we are talking about the main branch - it’s true. But the thing here that we create a PRs to the iroha2-dev branch specifically. A branch from fork is always rebased against the particular base upstream branch before to create a PR to it. Head and base branches …

Hi @tom ! I’m also seeing this issue. We disabled codecov a year ago due to the security issue, and we’re reenabling with the new uploader. Codecov is comparing to a report from last year (back when codecov was enabled) instead of the proper base on main. We’re not on a fork or using any flags. BASE…

Incorrect coverage changes reported - base commit not uploading?

Support

tom January 16, 2023, 8:50pm 13

(Responded here)

Topic		Replies	Views
CodeCov comment still says "consider uploading reports for the commit to get more accurate results" after reports have been uploaded Support github	6	857	September 26, 2022
Nearest Pull Request Base/PseudoBase Commit not chosen correctly Bug Fixes	23	1659	September 14, 2021
Unable to determine a parent commit to compare against in base branch after Squash and Merge Support	20	2460	April 8, 2021
Incorrect base commit of pull request Support github	5	782	August 19, 2020
Coverage report upload success, but result said some missing base report Bug Fixes	2	1067	November 4, 2020

Incorrect coverage changes reported - base commit not uploading?

Related topics