Codecov compare the coverage with a incorrect master

STRRL · June 18, 2021, 2:51am

Please search for similar issues before creating a ticket.
All fields below are required.

Description

codecov compare the coverage with a incorrect master

Commit SHAs

e4df5123a88d0716a40871c088ce2959e8659634

github.com/chaos-mesh/chaos-mesh

intergration tests for workflow

chaos-mesh:master ← STRRL:workflow-intergration-tests

opened 01:13PM - 16 Jun 21 UTC

STRRL

+937 -2

Signed-off-by: STRRL <str_ruiling@outlook.com> ### What problem does this PR …solve? Integration tests of workflow controllers. As the assertion of e2e is hard to write, this PR is a replacement of https://github.com/chaos-mesh/chaos-mesh/pull/1902. ### What is changed and how it works? it will use `envtest` and only bootstrap workflow controllers for testing. ### Related changes * PR to update `chaos-mesh/website`/`chaos-mesh/website-zh`: * Need to update Chaos Dashboard component, related issue: * Need to cheery-pick to the release branch ### Checklist Tests - [x] Unit test - [ ] E2E test - [x] Manual test (add detailed scripts or steps below) - [ ] No code Side effects - [ ] Breaking backward compatibility ### Release note ```release-note Please add a release note. If you don't think this PR needs a release note then fill it with None. ```

Repository

CI/CD or Build URL

We are using Github Action.

Uploader

Codecov Output

Expected Results

codecov compare the coverage between PR and Master

Actual Results

Codecov always compares the test coverage with one incorrect master ( master (7e9ff3f) ):

github.com/chaos-mesh/chaos-mesh

Comment by codecov-commenter to intergration tests for workflow

chaos-mesh:master ← STRRL:workflow-intergration-tests

# [Codecov](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980?src=pr&el=h1&u…tm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#1980](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (a15ae49) into [master](https://codecov.io/gh/chaos-mesh/chaos-mesh/commit/18ad8453fe73532116e744b36b4abda458cadeb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (18ad845) will **increase** coverage by `1.81%`. > The diff coverage is `44.90%`. [![Impacted file tree graph](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/graphs/tree.svg?width=650&height=150&src=pr&token=a3XIzuy5Dk&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## master #1980 +/- ## ========================================== + Coverage 39.47% 41.28% +1.81% ========================================== Files 17 126 +109 Lines 608 7591 +6983 ========================================== + Hits 240 3134 +2894 - Misses 337 4151 +3814 - Partials 31 306 +275 ``` | [Impacted Files](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [api/v1alpha1/awschaos\_types.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2F3c2NoYW9zX3R5cGVzLmdv) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/dnschaos\_type.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2Ruc2NoYW9zX3R5cGUuZ28=) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/dnschaos\_webhook.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2Ruc2NoYW9zX3dlYmhvb2suZ28=) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/gcpchaos\_types.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2djcGNoYW9zX3R5cGVzLmdv) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/httpchaos\_types.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2h0dHBjaGFvc190eXBlcy5nbw==) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/httpchaos\_webhook.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2h0dHBjaGFvc193ZWJob29rLmdv) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/iochaos\_types.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2lvY2hhb3NfdHlwZXMuZ28=) | `0.00% <0.00%> (-32.56%)` | :arrow_down: | | [api/v1alpha1/jvmchaos\_webhook.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2p2bWNoYW9zX3dlYmhvb2suZ28=) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/kernelchaos\_types.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL2tlcm5lbGNoYW9zX3R5cGVzLmdv) | `0.00% <0.00%> (ø)` | | | [api/v1alpha1/networkchaos\_types.go](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-YXBpL3YxYWxwaGExL25ldHdvcmtjaGFvc190eXBlcy5nbw==) | `0.00% <0.00%> (-14.44%)` | :arrow_down: | | ... and [195 more](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [445f20c...a15ae49](https://codecov.io/gh/chaos-mesh/chaos-mesh/pull/1980?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).

Actually, GitHub tells me “This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.”

Also, I click the "Continue to review full report at Codecov.', that webpage is also broken, with HTTP 400. ( Codecov )

I am not sure about that if there are some misconfigurations.

Additional Information

tom · July 6, 2021, 8:44pm

@STRRL sorry about the delay here. Are you still able to reproduce this with a newer commit?

Topic		Replies	Views
False Coverage reports Support python , circleci , github	0	568	July 24, 2019
Coverage is comparing with incorrect base branch Support golang , github	6	163	February 28, 2023
Codecov not properly processing coverage data Bug Fixes	2	363	November 1, 2019
Codecov badge shows unknown tough coverage profiles uploaded Bug Fixes github	3	368	May 5, 2022
Codecov incorrectly aggregates code coverage data Bug Fixes python , github	1	445	May 29, 2020