Files not being ignored

[ahopkins]

Description

Description of the issue

We have some files that are really irrelevant to our coverage, but cannot seem to ignore them.

ignore:
  - "*/**/__main__.py"
  - "*/**/reload_helpers.py"
  - "*/**/simple.py"
  - "*/**/utils.py"

I also tried:

ignore:
  - sanic/__main__.py
  - sanic/reload_helpers.py
  - sanic/simple.py
  - sanic/utils.py

Commit SHAs

2100624c26190b43f89e15777f7cd07b18915afb

Repository

GitHub - sanic-org/sanic: Next generation Python web server/framework | Build...

Add Simple Server and Coverage action

CI/CD or Build URL

Try glob ignore

Uploader

GH Action

Codecov Output

/usr/bin/bash codecov.sh -n sanic-coverage -F unittests -Q github-action-v1.5.2 -e OS,PYTHON -Z -f ./coverage.xml -v -q ./coverage/codecov_report.txt
+ curl_s=
+ getopts a:A:b:B:cC:dD:e:f:F:g:G:hi:J:k:Kn:p:P:Q:q:r:R:s:S:t:T:u:U:vx:X:Zz:N:- o
+ codecov_flags+=("$o")
+ case "$o" in
+ save_to=./coverage/codecov_report.txt
+ getopts a:A:b:B:cC:dD:e:f:F:g:G:hi:J:k:Kn:p:P:Q:q:r:R:s:S:t:T:u:U:vx:X:Zz:N:- o
+ say '
  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-1.0.3

'
+ echo -e '
  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-1.0.3

'
+ '[' '' = '' ']'

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-1.0.3
https://storage.googleapis.com/codecov/v4/raw/2021-06-17/8C14684F8CA94D38CE5A5E69A5E9E607/2100624c26190b43f89e15777f7cd07b18915afb/e4c867d5-e290-48d1-9c80-adb9e39123cb.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EKKHVKCKHW7KBCGM7IHR55T63V2PAVJWLVFNITJHDU5G6R5IRN3LMWJA%2F20210617%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20210617T072501Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=fbb219186d690c373e3ccd73144d921923e08e97b703bd4d3a39921f5c073aa7
++ curl -fiX PUT --data-binary @/tmp/codecov.MQxObV.gz -H 'Content-Type: application/x-gzip' -H 'Content-Encoding: gzip' 'https://storage.googleapis.com/codecov/v4/raw/2021-06-17/8C14684F8CA94D38CE5A5E69A5E9E607/2100624c26190b43f89e15777f7cd07b18915afb/e4c867d5-e290-48d1-9c80-adb9e39123cb.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EKKHVKCKHW7KBCGM7IHR55T63V2PAVJWLVFNITJHDU5G6R5IRN3LMWJA%2F20210617%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20210617T072501Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=fbb219186d690c373e3ccd73144d921923e08e97b703bd4d3a39921f5c073aa7'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 11696    0     0  100 11696      0  39117 --:--:-- --:--:-- --:--:-- 39117
+ s3='HTTP/2 200 
x-guploader-uploadid: ABg5-Uz_z3wTNYdzjxqfEIu9hwruFOh6O4NuKDO2-0cyUGoQWun41DxAWd4HXlHtf5iEPShWZRB6cnUW41WWd_fF-Is
etag: "40bf978384f6f23b33b6c4e92913c861"
x-goog-generation: 1623914701994023
x-goog-metageneration: 1
x-goog-hash: crc32c=3e+jPg==
x-goog-hash: md5=QL+Xg4T28jsztsTpKRPIYQ==
x-goog-stored-content-length: 11696
x-goog-stored-content-encoding: gzip
vary: Origin
content-length: 0
date: Thu, 17 Jun 2021 07:25:02 GMT
server: UploadServer
content-type: text/html; charset=UTF-8
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"

'
+ '[' 'HTTP/2 200 
x-guploader-uploadid: ABg5-Uz_z3wTNYdzjxqfEIu9hwruFOh6O4NuKDO2-0cyUGoQWun41DxAWd4HXlHtf5iEPShWZRB6cnUW41WWd_fF-Is
etag: "40bf978384f6f23b33b6c4e92913c861"
x-goog-generation: 1623914701994023
x-goog-metageneration: 1
x-goog-hash: crc32c=3e+jPg==
x-goog-hash: md5=QL+Xg4T28jsztsTpKRPIYQ==
x-goog-stored-content-length: 11696
x-goog-stored-content-encoding: gzip
vary: Origin
content-length: 0
date: Thu, 17 Jun 2021 07:25:02 GMT
server: UploadServer
content-type: text/html; charset=UTF-8
alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-T051=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"

' '!=' '' ']'
++ sed -n 1p
++ echo 'https://codecov.io/github/sanic-org/sanic/commit/2100624c26190b43f89e15777f7cd07b18915afb
https://storage.googleapis.com/codecov/v4/raw/2021-06-17/8C14684F8CA94D38CE5A5E69A5E9E607/2100624c26190b43f89e15777f7cd07b18915afb/e4c867d5-e290-48d1-9c80-adb9e39123cb.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EKKHVKCKHW7KBCGM7IHR55T63V2PAVJWLVFNITJHDU5G6R5IRN3LMWJA%2F20210617%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20210617T072501Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=fbb219186d690c373e3ccd73144d921923e08e97b703bd4d3a39921f5c073aa7
200'
+ say '    \033[0;32m->\033[0m Reports have been successfully queued for processing at \033[0;36mhttps://codecov.io/github/sanic-org/sanic/commit/2100624c26190b43f89e15777f7cd07b18915afb\033[0m'
+ echo -e '    \033[0;32m->\033[0m Reports have been successfully queued for processing at \033[0;36mhttps://codecov.io/github/sanic-org/sanic/commit/2100624c26190b43f89e15777f7cd07b18915afb\033[0m'
+ exit 0
    -> Reports have been successfully queued for processing at https://codecov.io/github/sanic-org/sanic/commit/2100624c26190b43f89e15777f7cd07b18915afb

Expected Results

To not see the ignored files on the coverage report: Code coverage done right.

Actual Results

Results for these files still seem to appear:

Additional Information

I looked on these forums and found some similar issues, but it does not seem to be related. From what I can gather, the problems people face tend to be with config issues.

• "ignore" option of codecov.yml is not working
• Ignore option not working - #5 by sushantmimani
• Ignore is not working for go project
• Codecov.yml Ignore not working - #11 by Ornias1993
• Ignore paths not being picked up in PR - #8 by drazisil

I have tried using the validation tool with both the glob and relative paths. It comes back valid both times. What am I missing?

cat codecov.yml | curl --data-binary @- https://codecov.io/validate

[tom]

@ahopkins sorry this took a while to get to. It looks like you are doing this on the coverage branch here. With the exception of reload_helpers which I think should be reloader_helpers. Are you still seeing this issue?

[ahopkins]

Thanks for the response. We are no longer using codecov in the project.

[tom]

@ahopkins got it, any reason in particular or something I can help with?