GitHub Check does not fail when Threshold crossed

Support Bug Fixes
,
1

Please search for similar issues before creating a ticket.
All fields below are required.

Description

I’m trying to integrate CodeCov into a Create React App project (using pnpm) which contains testable code located in various subfolders within the repository. I set both status.project.threshold and status.patch.threshold in the codecov.yml file to pretty low values (0% as well as 0.1%). I verified that the codecov.yml file was valid using the bash validation command. GitHub App integration has been enabled for this repository.

I created a dummy PR which removes existing unit tests (more than 2% project coverage), in order to trigger codecov thresholds set. This still does not fail my GitHub codecov check.

I’d like to know what configuration is incorrect/missing for this to work correctly. Also, why am I not seeing the codecov-specific checks “codecov/patch” and “codecov/project” as seen in this PR

Commit SHAs

N/A (Not commit-specific)

Repository

PR link added in description.

CI/CD or Build URL

N/A

Uploader

Bash uploader

Expected Results

GitHub check should fail when CodeCov threshold is crossed.

2

@SanketD92 I would highly recommend installing the app integration to fix this issue for you.

3

@tom App integration has been configured for this repo. Permissions granted are:

Permissions

  • Read access to administration, code, issues, members, and metadata
  • Read and write access to checks, commit statuses, and pull requests

Let me know if I’m misunderstanding something.

4

@SanketD92 I’m seeing that it isn’t on our end. If you’re sure it’s set, would you mind uninstalling and reinstalling? I think that should fix it for you.

5

@tom I see that repository access for awslabs/service-workbench-on-aws has been granted (on this link)

6

@SanketD92, I’m guessing something went wrong when getting the callback during installation. Are you able to uninstall and reinstall?

7

@tom Attempting uninstall and re-install now. I’ll keep you updated on this thread

8

That worked! Thanks @tom

1 Like