Large file issues

Support Bug Fixes
1

Description

Large files cause issues with the layout and performance. I understand that JS is not the fastest language out there so performance might be hard to optimize, but at least handling files >1000 lines without wrapping the line number should be supported.

See for example the file: Codecov

codecov_layout
codecov_layout895×561 35.5 KB

CI/CD URL

Codecov Output

  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-1.0.6


==> git version 2.33.1 found
==> curl 7.68.0 (x86_64-pc-linux-gnu) libcurl/7.68.0 OpenSSL/1.1.1f zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.2.0) libssh/0.9.3/openssl/zlib nghttp2/1.40.0 librtmp/2.3
Release-Date: 2020-01-08
Protocols: dict file ftp ftps gopher http https imap imaps ldap ldaps pop3 pop3s rtmp rtsp scp sftp smb smbs smtp smtps telnet tftp 
Features: AsynchDNS brotli GSS-API HTTP2 HTTPS-proxy IDN IPv6 Kerberos Largefile libz NTLM NTLM_WB PSL SPNEGO SSL TLS-SRP UnixSockets
==> GitHub Actions detected.
    Env vars used:
      -> GITHUB_ACTIONS:    true
      -> GITHUB_HEAD_REF:   overhaul
      -> GITHUB_REF:        refs/pull/24/merge
      -> GITHUB_REPOSITORY: bqqbarbhg/ufbx
      -> GITHUB_RUN_ID:     1484911293
      -> GITHUB_SHA:        b64e0a146682b5d23a198e214ce37d6a1e468fa0
      -> GITHUB_WORKFLOW:   CI
    Fixing merge commit SHA b64e0a146682b5d23a198e214ce37d6a1e468fa0 -> 82b21a960b2214c39c15935721ce4b4fa1de9499
    current dir:  /home/runner/work/ufbx/ufbx
    project root: .
    Yaml found at: .github/codecov.yml
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Reading reports
    + coverage.lcov bytes=406954
==> Appending adjustments
    https://docs.codecov.io/docs/fixing-reports
    + Found adjustments
==> Gzipping contents
        120K	/tmp/codecov.fWCP77.gz
==> Uploading reports
    url: https://codecov.io
    query: branch=overhaul&commit=82b21a960b2214c39c15935721ce4b4fa1de9499&build=1484911293&build_url=https%3A%2F%2Fgithub.com%2Fbqqbarbhg%2Fufbx%2Factions%2Fruns%2F1484911293&name=&tag=&slug=bqqbarbhg%2Fufbx&service=github-actions&flags=&pr=24&job=CI&cmd_args=f,?
->  Pinging Codecov
https://codecov.io/upload/v4?package=bash-1.0.6&token=<hidden>&package=bash-1.0.6&token=&branch=overhaul&commit=82b21a960b2214c39c15935721ce4b4fa1de9499&build=1484911293&build_url=https%3A%2F%2Fgithub.com%2Fbqqbarbhg%2Fufbx%2Factions%2Fruns%2F1484911293&name=&tag=&slug=bqqbarbhg%2Fufbx&service=github-actions&flags=&pr=24&job=CI&cmd_args=f,?
->  Uploading to
https://storage.googleapis.com/codecov/v4/raw/2021-11-20/3F8D76C74687296EE7C0575752971F48/82b21a960b2214c39c15935721ce4b4fa1de9499/1217c8b8-c337-4edb-b17f-0f214d0f180b.txt?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=GOOG1EKKHVKCKHW7KBCGM7IHR55T63V2PAVJWLVFNITJHDU5G6R5IRN3LMWJA%2F20211120%2FUS%2Fs3%2Faws4_request&X-Amz-Date=20211120T165012Z&X-Amz-Expires=10&X-Amz-SignedHeaders=host&X-Amz-Signature=bbd9441d7c60c650840126e72f893f7ad9120bb04dfa92266cad58bfb043dab4
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  118k    0     0  100  118k      0   425k --:--:-- --:--:-- --:--:--  425k
    -> Reports have been successfully queued for processing at https://codecov.io/github/bqqbarbhg/ufbx/commit/82b21a960b2214c39c15935721ce4b4fa1de9499

Expected Results

Opening a large file would display correctly after initially loading.

Actual Results

Viewing the file ufbx.c wraps line numbers causing awkward spacing in the output.

Additional Information

I’m not sure if this is a common problem across large files, but I’d guess it is.

1 Like
2

Thanks @bqqbarbhg, I’ll open a ticket with our product team, this is definitely a bug.

3

@bqqbarbhg, we made a fix for this, would you be able to see if it’s working for you now?

4

@tom Sorry for the late response, I didn’t get any notification for the reply. It works now perfectly for me, also the site seems to load a bit faster! Thanks and great work!

1 Like