Missing files in codecov (but not in report)

MoshiBin · December 20, 2019, 9:51pm

Description

Codecov is missing some of the files in my repo - but they do appear in the coverage report.

Notice how server.py and client.py are missing - but they show up on the report: https://codecov.io/codecov/v4/raw/2019-12-20/34749C3E1E6F8E0FD2B392F6B33CB864/2f2aa7bcdf794a57e132711f5e790e5d9b2bb7b5/acd4300b-d878-4196-b296-aa50f97fc396.txt

Repository

MoshiBin/ssdpy on github

jerrod · January 3, 2020, 2:31am

Hey @MoshiBin – thanks for reaching out! I was not able to reproduce this bug / I do see these two files in your repo view:

Can you let me know if this is still an issue?

Jerrod

MoshiBin · January 3, 2020, 1:09pm

These aren’t the same files - there are “client.py” and “server.py” both in ssdpy/ and in ssdpy/cli/:

github.com

MoshiBin/ssdpy/blob/master/ssdpy/client.py

# -*- coding: utf-8 -*-
from __future__ import absolute_import, division, print_function, unicode_literals

import socket
from .constants import ipv4_multicast_ip, ipv6_multicast_ip
from .http_helper import parse_headers
from .protocol import create_msearch_payload
from .compat import if_nametoindex


class SSDPClient(object):
    def __init__(
        self, proto="ipv4", port=1900, ttl=2, iface=None, timeout=5, *args, **kwargs
    ):
        allowed_protos = ("ipv4", "ipv6")
        if proto not in allowed_protos:
            raise ValueError(
                "Invalid proto - expected one of {}".format(allowed_protos)
            )
        self.port = port

This file has been truncated. show original

github.com

MoshiBin/ssdpy/blob/master/ssdpy/server.py

# -*- coding: utf-8 -*-
from __future__ import absolute_import, division, print_function, unicode_literals

import logging
import socket
import struct
from .constants import ipv6_multicast_ip, ipv4_multicast_ip
from .protocol import create_notify_payload
from .http_helper import parse_headers
from .compat import if_nametoindex


logger = logging.getLogger("ssdpy.server")


class SSDPServer(object):
    def __init__(
        self,
        usn,
        proto="ipv4",

This file has been truncated. show original

github.com

MoshiBin/ssdpy/blob/master/ssdpy/cli/client.py

# -*- coding: utf-8 -*-
from __future__ import absolute_import, division, print_function, unicode_literals

import argparse
import json
import logging
import pprint
from ..version import VERSION
from ..client import SSDPClient

logging.basicConfig()


def parse_args(argv):
    parser = argparse.ArgumentParser(description="Run an SSDP M-SEARCH",)
    parser.add_argument(
        "-V", "--version", action="version", version="%(prog)s {}".format(VERSION)
    )
    parser.add_argument("-v", "--verbose", help="Be more verbose", action="store_true")
    parser.add_argument(

This file has been truncated. show original

github.com

MoshiBin/ssdpy/blob/master/ssdpy/cli/server.py

# -*- coding: utf-8 -*-
from __future__ import absolute_import, division, print_function, unicode_literals

import argparse
import logging
from ..version import VERSION
from ..server import SSDPServer

logging.basicConfig()


def parse_args(argv):
    parser = argparse.ArgumentParser(description="Start an SSDP server")
    parser.add_argument(
        "-V", "--version", action="version", version="%(prog)s {}".format(VERSION)
    )
    parser.add_argument("-v", "--verbose", help="Be more verbose", action="store_true")
    proto_group = parser.add_mutually_exclusive_group()
    proto_group.add_argument(
        "-4", "--ipv4", help="Listen on IPv4 (default: True)", action="store_true"

This file has been truncated. show original

The ones outside of the cli folder aren’t in the coverage report

tom · April 24, 2020, 6:06pm

Hi @MoshiBin, apologies that you were not updated on this. We made a change in late January to fix this issue, can you check to see if this is still a problem?

fmigneault · May 17, 2020, 8:22am

I seem to be experiencing something similar on my repo:
https://codecov.io/gh/crim-ca/weaver

The file weaver/utils.py is missing for me although it clearly is in my coverage.xml report, whereas other utils.py files located at other level are present as expected.

(not found!) => https://codecov.io/gh/crim-ca/weaver/src/master/weaver/utils.py
(available) => https://codecov.io/gh/crim-ca/weaver/src/master/weaver/wps_restapi/utils.py
(available) => https://codecov.io/gh/crim-ca/weaver/src/master/weaver/processes/utils.py

Is it possible that some paths are not correctly resolved (ie: they get mixed up with same name files at other levels)?

fmigneault · May 22, 2020, 6:11pm

@tom I am seeing this issue as of today (2020-05-22T04:00:00Z), so this doesn’t seem related to the January changes.

The file getting ignored is available in the build:
https://codecov.io/codecov/v4/raw/2020-05-22/F30EF79C2304380A6469104F71A8547E/66f9db90691c4ea0f019e53cd4f563f9ea6b1ca6/72f0466e-0c4a-4dee-8ee4-5f07ae8640c5.txt
But is is not present in the listing:
https://codecov.io/gh/crim-ca/weaver/tree/66f9db90691c4ea0f019e53cd4f563f9ea6b1ca6/weaver

tom · May 22, 2020, 9:11pm

Hi @fmigneault, this looks like a path fixing issue. I’m going to take a stab and guess you’ll need to add this to a codecov.yml file

fixes:
  - "::weaver/"

Would you try that and see if it works?

fmigneault · May 27, 2020, 5:33am

Hi @tom

Using your suggestion, I went to the root of the cause and modified my setup.cfg to define source = ./ instead of source = weaver.
This solved it for me without adding codecov.yml file.

Thanks