I am trying to apply a threshold check to my project.
The project lives here. It currently has 82.19% code coverage. I have set a target of 80% and a threshold of 1% in my codecov.yml.
I have made a patch which decreases code coverage to be above the threshold and checks pass. That PR is located here. It has 80.88% (more than a 1% threshhold) but is still above the 80% target. This is not being reported as a failure.
I’ve also verified that my codecov.yml is valid, by running:
$ cat codecov.yml | curl --data-binary @- https://codecov.io/validate
Valid!
{
"coverage": {
"status": {
"project": {
"default": {
"threshold": 1.0,
"if_ci_failed": "error",
"base": "auto",
"target": 80.0
}
},
"patch": {
"default": {
"threshold": 1.0,
"if_ci_failed": "error",
"base": "auto",
"target": 80.0
}
}
}
}
}
I can’t figure out what I’m missing. Can anyone advise?