BUG: Project path prefix of codecov-action running on Windows is incorrectly kept in report data

bastimeyer · October 9, 2020, 8:00am

Description

It seems like the prefix of the project path on Github’s CI runners on Windows, eg. D:/a/USER/REPO, does not get removed anymore by codecov when reading the uploaded report.

This started happening after the recent outage and is causing a lot of troube in our repository, as the reports are all incorrect now and the PR checks with certains thresholds/targets are failing because of that. The recent commit on our master branch is also affected by this.

Repository

Affected master branch:

Example PR:

CI/CD

Github actions

Uploader

codecov-action

github.com

streamlink/streamlink/blob/cb5cee6109b98e61f98b42967185a379a4748e0a/.github/workflows/main.yml#L44-L49


- name: Upload coverage data
  if: github.event_name != 'schedule'
  continue-on-error: ${{ matrix.continue || false }}
  uses: codecov/codecov-action@v1
  with:
    name: os:${{ matrix.os }} py:${{ matrix.python }}

Commit SHAs

cb5cee6109b98e61f98b42967185a379a4748e0a
or
3b5a2cb6d870e2d875654791a91bf741c1dcf278

Codecov YAML

github.com

streamlink/streamlink/blob/cb5cee6109b98e61f98b42967185a379a4748e0a/.codecov.yml

codecov:
  notify:
    require_ci_to_pass: true
    # wait until at all test runners have uploaded a report (see the test job's build matrix)
    # otherwise, coverage failures may be shown while some reports are still missing
    after_n_builds: 12
comment:
  # this also configures the layout of PR check summaries / comments
  layout: "reach, diff, flags, files"
  # don't ever let the codecov bot comment on PRs
  after_n_builds: 999999999
coverage:
  range: "50...100"
  precision: 2
  round: down
  status:
    changes: false
    patch: false
    # split up coverage reports by path
    # don't set coverage targets and instead set coverage thresholds

This file has been truncated. show original

Codecov Output

samuelcolvin · October 9, 2020, 9:19am

We’re having the same problem on pydantic,

See https://github.com/samuelcolvin/pydantic/issues/1979.

Codecov team: it would be really great if you could fix this quickly.

tom · October 9, 2020, 5:19pm

Hi @bastimeyer and @samuelcolvin, thanks for bringing this up. I’ll update here and we investigate.

tom · October 9, 2020, 5:50pm

We have found the issue and made the fix here. We will be deploying shortly.

tom · October 9, 2020, 6:07pm

@bastimeyer, @samuelcolvin the fix is now deployed. Please let me know if you’re still experiencing this issue.