Mismatch between project and patch coverage

mattiaerre · February 25, 2020, 4:25am

Description

not sure why it looks like the coverage is dropped while the reports are showing an increase of .02%

Repository

github.com/prettier-solidity/prettier-plugin-solidity

Contract Definition comments

prettier-solidity:master ← prettier-solidity:bugfix/contract_definition_comments

opened 10:08PM - 01 Jul 19 UTC

Janther

+499 -78

fixes #162 in this PR there are 2 new features. 1. the indentation on `…BlockComment`s is now aligned with the indentation of the subject of that comment. 2. many edge cases on comments around contract definitions are addressed. input ```Solidity contract A { // solhint-disable-previous-line no-empty-blocks } ``` output won't even print currently. after this PR ```Solidity contract A { // solhint-disable-previous-line no-empty-blocks } ``` Scenarios, where we were depending on prettier to guess where the comment should go, are now addressed. input: ```Solidity contract A /*comment about the name*/ is X /*interface X because ...*/, Y /*contract Y because ...*/, Z /*implements Z because ...*/ { // solhint-disable-previous-line no-empty-blocks } ``` Output: ```Solidity contract A is /*comment about the name*/ X, /*interface X because ...*/ Y, /*contract Y because ...*/ Z /*implements Z because ...*/ // solhint-disable-previous-line no-empty-blocks {} ``` After this PR: ```Solidity /*comment about the name*/ contract A is X, /*interface X because ...*/ Y, /*contract Y because ...*/ Z /*implements Z because ...*/ { // solhint-disable-previous-line no-empty-blocks } ``` To address the Contract Definition edge cases I created the following functions `solidityHandleOwnLineComment`, `solidityHandleEndOfLineComment`, and `solidityHandleRemainingComment`, these functions try to match the comments with Solidity's cases first and if no match was found, they call the javascript comment handler respectively. My idea is to bring add Solidity's edge cases in this folder. and even redoing the javascript handlers in a way that makes sense with Solidity's AST. With time we will rely less on the javascript `handlers` while fully using the `utils`. Finally I had to add the `package-lock.json` because Travis kept installing the wrong eslint and failing to run the linting.

Versions

N/A

Additional Information

do you think is it safe to bypass this check and merge the PR?

thanks so much as usual,

jerrod · February 27, 2020, 5:28pm

@mattiaerre – jumping in directly in GH so rest of your community can see too

mattiaerre · February 28, 2020, 7:00am

thanks so much @jerrod much appreciated

Topic		Replies	Views
Add solidity as a supported language Feature Requests github	1	409	December 7, 2021
Losing coverage shows incorrect -/+ symbols Bug Fixes	3	383	May 22, 2020
Gh PR comment not updating Support github	5	504	November 24, 2020
Github Comment says the pull request didn't change any code Bug Fixes	2	371	May 22, 2020
Coverage dropped by > 60% after merging a commit Support	18	314	March 7, 2023

Mismatch between project and patch coverage

Description

Repository

Versions

Additional Information

Related topics