Missing checks on GitHub

Support
1

Description

Note: With a new account here, I can frustratingly only post one link. See Fix Codecov integration · Issue #3934 · python-pillow/Pillow · GitHub for this same report with the TODOs filled in.

Coverage reports are being created for PRs on Codecov, but most of the time they’re not showing as checks the PRs on GitHub. They used to. This makes it hard to see if the PR has tested the changed code.

  • TODO

Here’s 5 recent PRs, none have Codecov checks on GitHub:

  • TODO

These mostly show up on the Codecov website itself with coverage:

  • TODO
  • TODO
  • TODO
  • #3953: “No report uploaded yet.”
  • TODO

The most recent to have a Codecov check on GitHub was 8 days ago, but there are older ones without checks:

  • TODO

Repository

  • TODO

Versions

codecov 2.0.15 for Python

2

Hi @hugovk

We fixed a bug last night with stuck statuses. Can you please push a fresh commit and let me know if you are still seeing this issue?

3

Hi @drazisil, thanks for the quick reply!

I restarted the Travis CI build for 5 PRs. This now had Codecov checks on the PR:

These don’t:

I can see them at Codecov, but not as checks.

Should it only work for fresh commits, or should restarting it also help?

Thank you!

4

Hi @hugovk

Restarting should do it. Can you visit https://codecov.io/gh/python-pillow/Pillow/commit/386002e8923ec9586d4221529963c22f01212ac4/build and tell it to send notifications and let me know if that works?

It looks like the base commit may be stuck too https://codecov.io/gh/python-pillow/Pillow/commit/1c57a41ececc4529520a423b9bec13c78927cb25/build

5

Hi @drazisil, I sent the notifications and that PR now has the checks: Changed overflow check to use PY_SSIZE_T_MAX by radarhere · Pull Request #3964 · python-pillow/Pillow · GitHub.

Should I do the same for the other PRs?

1 Like
6

Hi @hugovk

Yes, please. Let me know if that doesn’t fix them.

7

For the old PR Documented more encoding values by radarhere · Pull Request #3969 · python-pillow/Pillow · GitHub I pushed notifications at Codecov and the checks show up :white_check_mark:

But I created a new PR today, Remove indirect dependencies from requirements.txt by hugovk · Pull Request #3976 · python-pillow/Pillow · GitHub, and it doesn’t have the checks.

Its corresponding Codecov says:

Notifications are pending CI completion. Waiting for GitHub’s status webhook to queue notifications. Push notifications now.

Any idea why that is?

8

Not sure. I manually pushed them, I wonder if one of the CI runs took long enough for the checks to timeout. How long do the runs generally take?

9

The slowest is AppVeyor, which usually takes 45-60 minutes for all the jobs to complete in series.

https://ci.appveyor.com/project/python-pillow/Pillow/history

10

Looking at PR Corrected tag type by radarhere · Pull Request #3981 · python-pillow/Pillow · GitHub, there are 20 Travis CI jobs and 10 AppVeyor jobs which send coverage.

However, 4 Travis jobs are missing from https://codecov.io/gh/python-pillow/Pillow/commit/9b26ea2164f14ad9e6b4b133d9e56eeef6671345/build

  • 7775.4
  • 7775.6
  • 7775.15
  • 7775.19

They’re all green at Travis CI - Test and Deploy Your Code with Confidence

However, 3 timed out uploading to S3 when running codecov:

==> Uploading
    .url https://codecov.io
    .query commit=9b26ea2164f14ad9e6b4b133d9e56eeef6671345&branch=master&job=561296506&pr=3981&service=travis&build=7775.4&slug=python-pillow%2FPillow&yaml=.codecov.yml&package=py2.0.15
    Pinging Codecov...
    Uploading to S3...
Error: HTTPSConnectionPool(host='codecov.io', port=443): Max retries exceeded with url: /codecov/v4/raw/2019-07-20/A516DB1BB8B4FFBA3C8D154F4B502F22/9b26ea2164f14ad9e6b4b133d9e56eeef6671345/8db867f0-7252-43d2-93cd-28a325d23400.txt?AWSAccessKeyId=AKIAIHLZSCQCS4WIHD4A&Expires=1563593005&Signature=Oho8rN93UdDP7%2FG7eIy3mvrmX%2B4%3D (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7fa4495c6e48>: Failed to establish a new connection: [Errno 110] Connection timed out'))

The 4th has a problem installing a dependency before running codecov:

11

Here’s a PR which fixes the dependency install problem:

The check is still missing, and one AppVeyor job timed out uploading to S3: